318 stalling from idle

It looks like your vacuum advance is not hooked up correctly. It requires ported vacuum usually from the front of the carb where you have attached the choke pull-off. That diaphragm requires full time vacuum. With vacuum hoses improperly connected, re-check your timing, maybe 6-8* advanced. Advance and choke diaphragms are crossed. No spring belongs on the choke linkage.