1970 Chevelle 396 HEI Ignition No Spark

I replaced the ignition module with an NOS unit. Now, I don't know if this was a bad idea because someone had mentioned that modules like this have a shelf life

That is not so. They do not degrade or expire from sitting on a shelf. But you do have to make sure your coil, pickup, and module are correctly matched; read the second post in this thread (and yeah, the ground strap has to be in place or no vroom)

I maybe should've just gotten one from Autozone.

Those are poorer quality than the ones made years ago.